Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add check delete json function #7113

Merged
merged 3 commits into from
Sep 21, 2023
Merged

util: add check delete json function #7113

merged 3 commits into from
Sep 21, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 19, 2023

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
util: add check delete json function
9828e0c 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
add code
cb185e6 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 19, 2023
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #7113 (cb185e6) into master (5b3d017) will increase coverage by 0.03%.
The diff coverage is 57.89%.

❗ Current head cb185e6 differs from pull request most recent head 52a6d0e. Consider uploading reports for the commit 52a6d0e to get more accurate results

@@            Coverage Diff             @@
##           master    #7113      +/-   ##
==========================================
+ Coverage   74.37%   74.41%   +0.03%     
==========================================
  Files         440      439       -1     
  Lines       47209    46941     -268     
==========================================
- Hits        35114    34932     -182     
+ Misses       9007     8936      -71     
+ Partials     3088     3073      -15
Flag Coverage Δ
unittests 74.41% <57.89%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

rleungx
rleungx reviewed Sep 19, 2023
View reviewed changes
pkg/utils/testutil/api_check.go
func checkResp(resp *http.Response, checkOpts ...func([]byte, int, http.Header)) error {
res, err := io.ReadAll(resp.Body)
resp.Body.Close()
defer resp.Body.Close()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem no need to change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems so.

@lhy1024 lhy1024 mentioned this pull request Sep 19, 2023
Merged
HuSharp
HuSharp approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 21, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cb185e6

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e2f1269 into tikv:master Sep 21, 2023
19 checks passed
@lhy1024 lhy1024 mentioned this pull request Oct 9, 2023
Closed
25 tasks
@rleungx rleungx mentioned this pull request Oct 9, 2023
Closed
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@lhy1024 @ti-chi-bot @rleungx
util: add check delete json function (tikv#7113)
0537643 
ref tikv#4399

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuSharp HuSharp HuSharp approved these changes

@rleungx rleungx rleungx approved these changes

@disksing disksing Awaiting requested review from disksing

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhy1024 @rleungx @HuSharp